Interesting question! I also wondered how much more security you gain by creating a second user.
I also tried out FileVault which can be choosen when the new user is created. Does that help in any way?
How secure is that?
If you're running both useres with quick change and you are loged in as the second user (where you install your savings wallet) is said user threatend by the other user's (everyday account) vulnerablity ?
Here's the problem with encrypted drives, that people seem to gloss over when coming up with these strategies (FileVault is no exception, if the drive is mounted, the data on the drive is accessible):
The Bitcoin GUI needs to be able to read the wallet.dat file in an unencrypted form.
In order to USE the wallet.dat with the GUI, you have to mount the drive (at which point it is UNENCRYPTED to your user space, i.e. ANY applications you run as you can access the wallet.dat unencrypted).
If the drive is mounted, and you allow something to run as you, it can be easily stolen and having it stored on an encrypted drive is useless.
Encryption, by itself, is not a solution.
Should you encrypt it? Sure, I store my wallet.dat in an encrypted volume on my Dropbox. However, that only protects it from someone getting into my Dropbox and stealing it. It doesn't protect it from me getting a trojan, spyware, etc. on my local computer while I have the drive mounted.