In fact many of the crypto users in my circle are the one who use a non custodial wallet.
It makes sense to use these wallets since these are better than centralized ones but if the amount of crypto is anywhere more than $1000,
then I think it is better to invest a few dollars in buying a hardware wallet instead.
It is a one time investment after all.
I mean sure if you want to, but I do not see the point of it. My entire savings are in 3 places right now, one is binance, the biggest one, second is metamask which is technically good and allows you to do easily what you would normally be able to do yourself anyway, and lastly a tiny bit in electrum, nothing big there though, it is very small and could be hacked today and I wouldn't care, it would be scary to know I am hacked, but not to know I lost that small amount.
So, I never had the feel to buy a ledger or a trezor or anything like that, metamask type of stuff are understandable, but thats about it, I do not think that physical ones are really needed.