I think it is best to keep your funds in your exchange wallet . Tho you should be careful on which exchange site you are going to store it . Make sure they have a good reputation or background on their security . I mean , no history of being hacked for long term . It is good practice to keep your funds in exchange site if you are a constant trader .
Keeping it in the wallet - This is good only if you want to withdraw or convert your balance into paper money . I mean , wallet can be stolen . hacked . If you have a hardware wallet then its the best option if you just want to protect your funds .
So it still depends on what purpose you want . If your a trader then keep it in your exchange wallet , because if you keep transferring your funds into your wallet , problems may come up like slow/high transaction fees . And during dips , you need your fund to be readily available always . On the other hand , if you just want to secure your $$ then like i said a hardware wallet is the bext option for that .
It is of course not good to put your coins on exchange wallet unless you are ready to trade every day but if you aren't and just want to hold, you are putting your coins in danger. There is no safe place unless its going to be in a wallet that you hold the private key. This is the most important of all that someone in the crypto should put in their minds. As a matter of fact we discourage systems that asks our private key as its like giving a password.